3502: wrong DPS values on weapons

Reported by ☆ Facetank at Sat, 04 Feb 2017 19:10:23 UTC
gamemechanic bug
invalid

Description

a friend crafted a steel longsword which had 5.3 base dps.
this was strange because BaseDPS := itemLevel * 0.3 + 1.2
merchants sell steel longswords with 5.4 base dps
i checked allakhazam and found an interesting screen shot
http://camelot.allakhazam.com/item.html?citem=2118

Even on live servers the item information box displayed 5.3 while the delve had 5.4 base dps.

The only thing i could imagine is that mythic used a floating point datatype to store BaseDPS (for whatever reason!!), while they used an integer type for dps in the item information sent to the client
>> intBaseDPS = (int) (floatBaseDPS * 10)
while they use the floating point value for internal calculations.
since the item delve contains calculated values based on condition and quality i'd guess they simply round their calculated values before converting it to a string.

Reproduction Steps

50 characters
50 characters
50 characters
50 characters

Intended Behavior

You should check your database for wrong values (dps % 3 != 0).

PS: would be cool to let me know how many items are affected
PPS: maybe you should check the af of all items as well:
((armortype == cloth) && (af < 1 || af > 51)) || ((armortype != cloth) && (af < 2 || af > 102 || (af % 2 == 1)))

Evidence

already posted before
50 characters
50 characters
50 characters

Status

Issue was invalid:
Invalid
3 players say this report is valid, 0 disagree

Comments

Loading Comments...